mongo: use db.system instead of db.type #335

vmihailenco · 2020-09-10T14:22:12Z

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md has db.system, but no db.type. It also recommends to use mongodb as system.

linux-foundation-easycla · 2020-09-10T14:22:15Z

The committers are authorized under a signed CLA.

✅ Vladimir Mihailenco (2f85b84)

* Add tests for nonabsolute and varying sign values * Implement support for NonAbsolute Measurement MaxSumCount Previously, the MaxSumCount aggregator failed to work correctly with negative numbers (e.g. MeasureKind Alternate()==true). * Pass NumberKind to MaxSumCount New() function Allows it to set the initial state (current.max) to the correct value based on the NumberKind. * Revert extraneous local change * Pass full descriptor to msc New() This is analagous to the DDSketch New() constructor * Remember to run make precommit first * Add tests for empty checkpoint of MaxSumCount aggregator An empty checkpoint should have Sum() == 0, Count() == 0 and Max() still equal to the numberKind.Minimum() * Return ErrEmptyDataSet if no value set by the aggregator Remove TODO from stdout exporter to ensure that if a maxsumcount or ddsketch aggregator returns ErrEmptyDataSet from Max(), then the entire record will be skipped by the exporter. Added tests to ensure the exporter doesn't send any updates for EmptyDataSet checkpoints - for both ddsketch and maxsumcount. * Relayout Aggreggator struct to ensure int64s are 8-byte aligned On 32-bit architectures, Go only guarantees that primitive values are aligned to a 4 byte boundary. Atomic operations on 32-bit machines require 8-byte alignment. See golang/go#599 * Addressing PR comments The use of Minimum() for the default uninitialized Maximum value means that in the unlikely condition that every recorded value for a measure is equal to the same NumberKind.Minimum(), then the aggregator's Max() will return ErrEmptyDataSet * Fix PR merge issue

mongo: use db.system instead of db.type

2f85b84

vmihailenco requested review from Aneurysm9, evantorrie, jmacd, lizthegrey, MrAlias and XSAM as code owners September 10, 2020 14:22

MrAlias approved these changes Sep 10, 2020

View reviewed changes

Aneurysm9 approved these changes Sep 10, 2020

View reviewed changes

Aneurysm9 merged commit 5997cc3 into open-telemetry:master Sep 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mongo: use db.system instead of db.type #335

mongo: use db.system instead of db.type #335

vmihailenco commented Sep 10, 2020

linux-foundation-easycla bot commented Sep 10, 2020 •

edited

Loading

mongo: use db.system instead of db.type #335

mongo: use db.system instead of db.type #335

Conversation

vmihailenco commented Sep 10, 2020

linux-foundation-easycla bot commented Sep 10, 2020 • edited Loading

linux-foundation-easycla bot commented Sep 10, 2020 •

edited

Loading