Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cloud.{account.id,availability_zone,region} in AWS ECS detector #4860

Merged
merged 17 commits into from
Feb 6, 2024

Conversation

mmanciop
Copy link
Contributor

No description provided.

@mmanciop mmanciop requested a review from a team January 26, 2024 13:25
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a1b4b4d) 80.3% compared to head (0a7560d) 81.6%.
Report is 1 commits behind head on main.

❗ Current head 0a7560d differs from pull request most recent head 0371b18. Consider uploading reports for the commit 0371b18 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4860     +/-   ##
=======================================
+ Coverage   80.3%   81.6%   +1.3%     
=======================================
  Files        151     151             
  Lines      10209   10916    +707     
=======================================
+ Hits        8201    8913    +712     
+ Misses      1854    1839     -15     
- Partials     154     164     +10     
Files Coverage Δ
detectors/aws/ecs/ecs.go 61.2% <83.3%> (+23.4%) ⬆️

... and 19 files with indirect coverage changes

detectors/aws/ecs/ecs.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
detectors/aws/ecs/ecs.go Show resolved Hide resolved
detectors/aws/ecs/ecs.go Show resolved Hide resolved
detectors/aws/ecs/ecs.go Show resolved Hide resolved
detectors/aws/ecs/ecs.go Outdated Show resolved Hide resolved
detectors/aws/ecs/ecs.go Show resolved Hide resolved
detectors/aws/ecs/ecs.go Show resolved Hide resolved
detectors/aws/ecs/ecs.go Show resolved Hide resolved
@mmanciop mmanciop requested a review from MrAlias January 30, 2024 11:29
@mmanciop
Copy link
Contributor Author

mmanciop commented Feb 6, 2024

Then test coverage build failure is about the automation failing to upload the result. I have seen it failing every other time or so on this PR.

@MrAlias MrAlias merged commit de64a47 into open-telemetry:main Feb 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants