Fix error in GitHub Actions integration tests #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
AzfaarQureshi
changed the title
MrAlias
approved these changes
Dec 17, 2020
XSAM
approved these changes
Dec 18, 2020
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* opentelemetry collector exporter - missing load test - missing resources * fix review comments. * add test for each SpanKind and Attribute Type. * rename otelcol to otlp * move exporter/trace/otlp to exporters/otlp * more review comments. * add alignment test. * pass context to uploadSpans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests can't actually compare to
origin/masterbecause the entire git tree wasn't being cloned in the action 😞 I fixed this by settingfetch-depthto 0.Missed this because the failure was silent and the job is actually passing because the makefile continues onto the last step (and returns a success exit code) instead of aborting at the fatal error.