processors/baggage: add baggage span processor #5404

codeboten · 2024-04-18T20:03:40Z

Fixes #5397

Fixes open-telemetry#5397 Signed-off-by: Alex Boten <[email protected]>

Signed-off-by: Alex Boten <[email protected]>

processors/baggage/processor_test.go

processors/baggage/processor.go

codeboten · 2024-04-18T20:47:21Z

Thanks for the quick review @pellared! Will address your comments shortly

Signed-off-by: Alex Boten <[email protected]>

Co-authored-by: Robert Pająk <[email protected]>

Signed-off-by: Alex Boten <[email protected]>

pellared · 2024-04-19T14:43:43Z

Can you also update the README.md? I see this is the first processor. Shouldn't we have a "split" for trace and log processors? I think we could have a similar log record processor.

Signed-off-by: Alex Boten <[email protected]>

codeboten · 2024-04-19T15:59:27Z

@pellared i've updated the readme and moved the contents of the baggage package for traces under baggage/baggagetrace to follow the exporters pattern in the go repo.

Signed-off-by: Alex Boten <[email protected]>

dmathieu

How about adding an example_test?

CHANGELOG.md

pellared

Just nit comments to address

Overall, LGTM

processors/baggage/baggagetrace/doc.go

Co-authored-by: Damien Mathieu <[email protected]>

CHANGELOG.md

processors/baggage/baggagetrace/doc.go

CODEOWNERS

Co-authored-by: Robert Pająk <[email protected]>

codecov · 2024-04-22T16:33:36Z

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.4%. Comparing base (f251adc) to head (407c7df).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #5404   +/-   ##
=====================================
  Coverage   62.4%   62.4%           
=====================================
  Files        189     190    +1     
  Lines      11638   11646    +8     
=====================================
+ Hits        7263    7271    +8     
- Misses      4158    4159    +1     
+ Partials     217     216    -1

Files	Coverage Δ
processors/baggage/baggagetrace/processor.go	`75.0% <75.0%> (ø)`

... and 1 file with indirect coverage changes

codeboten · 2024-04-26T14:57:52Z

I see this is approved, was there more work needed before merging this?

pellared · 2024-04-26T15:22:21Z

I see this is approved, was there more work needed before merging this?

It was discussed during last SIG meetings. We just want to have more reviews.

CODEOWNERS

MikeGoldsmith · 2024-05-02T11:45:46Z

I see this is approved, was there more work needed before merging this?

It was discussed during last SIG meetings. We just want to have more reviews.

Hey @pellared - what is the best way to get more community reviews? This PR has been open for more than two weeks and only a couple of approvers have provided feedback.

Do you have a sense how many reviews and/or how long you'd want to wait for additional reviews before accepting?

Is it specific people whom you would like to provide feedback?

Co-authored-by: Mike Goldsmith <[email protected]>

MikeGoldsmith · 2024-05-03T14:01:57Z

FYI the CI failure is from codecov being rate limited:

debug - 2024-05-02 15:31:38,221 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 429', params={}, description='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 491 seconds.\"}'), warnings=[], status_code=429, text='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 491 seconds.\"}')"}
error - 2024-05-02 15:31:38,221 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 491 seconds."}

pellared · 2024-05-06T15:02:38Z

@MrAlias, if I remember correctly you wanted to review this PR as well.

* processors/baggage: add baggage span processor Fixes open-telemetry#5397 Signed-off-by: Alex Boten <[email protected]> * fix lint issues + dependabot generate Signed-off-by: Alex Boten <[email protected]> * apply review feedback Signed-off-by: Alex Boten <[email protected]> * more review feedback Signed-off-by: Alex Boten <[email protected]> * Update processors/baggage/processor_test.go Co-authored-by: Robert Pająk <[email protected]> * lint Signed-off-by: Alex Boten <[email protected]> * feedback from review Signed-off-by: Alex Boten <[email protected]> * rename baggage -> baggagetrace Signed-off-by: Alex Boten <[email protected]> * more fixes Signed-off-by: Alex Boten <[email protected]> * docs Signed-off-by: Alex Boten <[email protected]> * lint fixes Signed-off-by: Alex Boten <[email protected]> * generate Signed-off-by: Alex Boten <[email protected]> * Update CHANGELOG.md Co-authored-by: Damien Mathieu <[email protected]> * Update CHANGELOG.md * Update processors/baggage/baggagetrace/doc.go * Apply suggestions from code review Co-authored-by: Robert Pająk <[email protected]> * Update processors/baggage/baggagetrace/processor.go Co-authored-by: Robert Pająk <[email protected]> * Apply suggestions from code review * Update CHANGELOG.md * Update CODEOWNERS Co-authored-by: Mike Goldsmith <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Damien Mathieu <[email protected]> Co-authored-by: Mike Goldsmith <[email protected]> Co-authored-by: Aaron Clawson <[email protected]>

### Added - Add the new `go.opentelemetry.io/contrib/instrgen` package to provide auto-generated source code instrumentation. (#3068, #3108) - Add an experimental `OTEL_METRICS_PRODUCERS` environment variable to `go.opentelemetry.io/contrib/autoexport` to be set metrics producers. (#5281) - `prometheus` and `none` are supported values. You can specify multiple producers separated by a comma. - Add `WithFallbackMetricProducer` option that adds a fallback if the `OTEL_METRICS_PRODUCERS` is not set or empty. - The `go.opentelemetry.io/contrib/processors/baggage/baggagetrace` module. This module provides a Baggage Span Processor. (#5404) - Add gRPC trace `Filter` for stats handler to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#5196) - Add a repository Code Ownership Policy. (#5555) - The `go.opentelemetry.io/contrib/bridges/otellogrus` module. This module provides an OpenTelemetry logging bridge for `github.com/sirupsen/logrus`. (#5355) - The `WithVersion` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the logged package version. (#5588) - The `WithSchemaURL` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the semantic convention schema URL for the logged records. (#5588) - Add support for Cloud Run jobs in `go.opentelemetry.io/contrib/detectors/gcp`. (#5559) ### Changed - The gRPC trace `Filter` for interceptor is renamed to `InterceptorFilter`. (#5196) - The gRPC trace filter functions `Any`, `All`, `None`, `Not`, `MethodName`, `MethodPrefix`, `FullMethodName`, `ServiceName`, `ServicePrefix` and `HealthCheck` for interceptor are moved to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor`. With this change, the filters in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` are now working for stats handler. (#5196) - `NewLogger` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the underlying `Handler`. (#5588) - `NewHandler` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the returned `Handler`. (#5588) - Upgrade all dependencies of `go.opentelemetry.io/otel/semconv/v1.24.0` to `go.opentelemetry.io/otel/semconv/v1.25.0`. (#5605) ### Removed - The `WithInstrumentationScope` option function in `go.opentelemetry.io/contrib/bridges/otelslog` is removed. Use the `name` parameter added to `NewHandler` and `NewLogger` as well as `WithVersion` and `WithSchema` as replacements. (#5588) ### Deprecated - The `InterceptorFilter` type in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` is deprecated. (#5196)

### Added - Add the new `go.opentelemetry.io/contrib/instrgen` package to provide auto-generated source code instrumentation. (open-telemetry#3068, open-telemetry#3108) - Add an experimental `OTEL_METRICS_PRODUCERS` environment variable to `go.opentelemetry.io/contrib/autoexport` to be set metrics producers. (open-telemetry#5281) - `prometheus` and `none` are supported values. You can specify multiple producers separated by a comma. - Add `WithFallbackMetricProducer` option that adds a fallback if the `OTEL_METRICS_PRODUCERS` is not set or empty. - The `go.opentelemetry.io/contrib/processors/baggage/baggagetrace` module. This module provides a Baggage Span Processor. (open-telemetry#5404) - Add gRPC trace `Filter` for stats handler to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (open-telemetry#5196) - Add a repository Code Ownership Policy. (open-telemetry#5555) - The `go.opentelemetry.io/contrib/bridges/otellogrus` module. This module provides an OpenTelemetry logging bridge for `github.com/sirupsen/logrus`. (open-telemetry#5355) - The `WithVersion` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the logged package version. (open-telemetry#5588) - The `WithSchemaURL` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the semantic convention schema URL for the logged records. (open-telemetry#5588) - Add support for Cloud Run jobs in `go.opentelemetry.io/contrib/detectors/gcp`. (open-telemetry#5559) ### Changed - The gRPC trace `Filter` for interceptor is renamed to `InterceptorFilter`. (open-telemetry#5196) - The gRPC trace filter functions `Any`, `All`, `None`, `Not`, `MethodName`, `MethodPrefix`, `FullMethodName`, `ServiceName`, `ServicePrefix` and `HealthCheck` for interceptor are moved to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor`. With this change, the filters in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` are now working for stats handler. (open-telemetry#5196) - `NewLogger` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the underlying `Handler`. (open-telemetry#5588) - `NewHandler` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the returned `Handler`. (open-telemetry#5588) - Upgrade all dependencies of `go.opentelemetry.io/otel/semconv/v1.24.0` to `go.opentelemetry.io/otel/semconv/v1.25.0`. (open-telemetry#5605) ### Removed - The `WithInstrumentationScope` option function in `go.opentelemetry.io/contrib/bridges/otelslog` is removed. Use the `name` parameter added to `NewHandler` and `NewLogger` as well as `WithVersion` and `WithSchema` as replacements. (open-telemetry#5588) ### Deprecated - The `InterceptorFilter` type in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` is deprecated. (open-telemetry#5196)

processors/baggage: add baggage span processor

9f17aed

Fixes open-telemetry#5397 Signed-off-by: Alex Boten <[email protected]>

codeboten requested review from MrAlias, MadVikingGod, pellared and dashpole as code owners April 18, 2024 20:03

codeboten requested a review from a team April 18, 2024 20:03

fix lint issues + dependabot generate

33e94b2

Signed-off-by: Alex Boten <[email protected]>

pellared reviewed Apr 18, 2024

View reviewed changes

processors/baggage/processor.go Outdated Show resolved Hide resolved

codeboten and others added 4 commits April 18, 2024 14:52

apply review feedback

b65b129

Signed-off-by: Alex Boten <[email protected]>

more review feedback

cfa0e23

Signed-off-by: Alex Boten <[email protected]>

Update processors/baggage/processor_test.go

8e648db

Co-authored-by: Robert Pająk <[email protected]>

lint

9ed5020

Signed-off-by: Alex Boten <[email protected]>

codeboten added 2 commits April 19, 2024 08:55

feedback from review

fa28a2f

Signed-off-by: Alex Boten <[email protected]>

rename baggage -> baggagetrace

26a0d60

Signed-off-by: Alex Boten <[email protected]>

codeboten added 4 commits April 19, 2024 09:01

more fixes

1a79494

Signed-off-by: Alex Boten <[email protected]>

docs

9bd6d4e

Signed-off-by: Alex Boten <[email protected]>

lint fixes

5e10970

Signed-off-by: Alex Boten <[email protected]>

generate

2d8ed5d

Signed-off-by: Alex Boten <[email protected]>

dmathieu reviewed Apr 22, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pellared reviewed Apr 22, 2024

View reviewed changes

processors/baggage/baggagetrace/doc.go Outdated Show resolved Hide resolved

Update CHANGELOG.md

e689203

Co-authored-by: Damien Mathieu <[email protected]>

codeboten commented Apr 22, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

32a3bc4

codeboten commented Apr 22, 2024

View reviewed changes

processors/baggage/baggagetrace/doc.go Outdated Show resolved Hide resolved

codeboten and others added 2 commits April 22, 2024 07:06

Update processors/baggage/baggagetrace/doc.go

262dda0

Merge branch 'main' into codeboten/processor-baggage

a75b628

codeboten commented Apr 22, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

codeboten and others added 2 commits April 22, 2024 08:10

Apply suggestions from code review

d710414

Co-authored-by: Robert Pająk <[email protected]>

Update processors/baggage/baggagetrace/processor.go

85ecca9

Co-authored-by: Robert Pająk <[email protected]>

pellared approved these changes Apr 22, 2024

View reviewed changes

dmathieu approved these changes Apr 22, 2024

View reviewed changes

Apply suggestions from code review

2d83729

MikeGoldsmith mentioned this pull request Apr 23, 2024

split components module honeycombio/honeycomb-opentelemetry-go#203

Closed

pellared added 2 commits April 25, 2024 08:26

Merge branch 'main' into codeboten/processor-baggage

a54abb1

Update CHANGELOG.md

ad3171e

MikeGoldsmith mentioned this pull request Apr 25, 2024

[OpenTelemetry.Extensions] Add baggage Activity processor open-telemetry/opentelemetry-dotnet-contrib#1659

Merged

3 tasks

MikeGoldsmith mentioned this pull request Apr 29, 2024

Project is being Sunset honeycombio/honeycomb-opentelemetry-go#205

Open

MikeGoldsmith approved these changes Apr 30, 2024

View reviewed changes

Merge branch 'main' into codeboten/processor-baggage

55fad94

MikeGoldsmith reviewed May 2, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

dmathieu and others added 2 commits May 2, 2024 14:06

Update CODEOWNERS

7211096

Co-authored-by: Mike Goldsmith <[email protected]>

Merge branch 'main' into codeboten/processor-baggage

fa1d812

Merge branch 'main' into codeboten/processor-baggage

782cf2f

MadVikingGod approved these changes May 6, 2024

View reviewed changes

Merge branch 'main' into codeboten/processor-baggage

407c7df

MrAlias merged commit 31c8398 into open-telemetry:main May 6, 2024
23 checks passed

MrAlias mentioned this pull request May 21, 2024

Release v1.27.0/v0.52.0/v0.21.0/v0.7.0/v0.2.0 #5628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

processors/baggage: add baggage span processor #5404

processors/baggage: add baggage span processor #5404

codeboten commented Apr 18, 2024

codeboten commented Apr 18, 2024

pellared commented Apr 19, 2024 •

edited

Loading

codeboten commented Apr 19, 2024

dmathieu left a comment

pellared left a comment

codecov bot commented Apr 22, 2024 •

edited

Loading

codeboten commented Apr 26, 2024

pellared commented Apr 26, 2024

MikeGoldsmith commented May 2, 2024

MikeGoldsmith commented May 3, 2024 •

edited

Loading

pellared commented May 6, 2024

processors/baggage: add baggage span processor #5404

processors/baggage: add baggage span processor #5404

Conversation

codeboten commented Apr 18, 2024

codeboten commented Apr 18, 2024

pellared commented Apr 19, 2024 • edited Loading

codeboten commented Apr 19, 2024

dmathieu left a comment

Choose a reason for hiding this comment

pellared left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 22, 2024 • edited Loading

Codecov Report

codeboten commented Apr 26, 2024

pellared commented Apr 26, 2024

MikeGoldsmith commented May 2, 2024

MikeGoldsmith commented May 3, 2024 • edited Loading

pellared commented May 6, 2024

pellared commented Apr 19, 2024 •

edited

Loading

codecov bot commented Apr 22, 2024 •

edited

Loading

MikeGoldsmith commented May 3, 2024 •

edited

Loading