Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting per-request custom metrics in gRPC stats handler. #6092

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into grpc-per-rpc-metric-attributes

b474ced
Select commit
Loading
Failed to load commit list.
Draft

Allow setting per-request custom metrics in gRPC stats handler. #6092

Merge branch 'main' into grpc-per-rpc-metric-attributes
b474ced
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 0s

65.7% (-0.1%) compared to 8a49875

View this Pull Request on Codecov

65.7% (-0.1%) compared to 8a49875

Details

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.7%. Comparing base (8a49875) to head (b474ced).

Files with missing lines Patch % Lines
...entation/google.golang.org/grpc/otelgrpc/config.go 0.0% 5 Missing ⚠️
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 0.0% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6092     +/-   ##
=======================================
- Coverage   65.7%   65.7%   -0.1%     
=======================================
  Files        203     203             
  Lines      13037   13044      +7     
=======================================
+ Hits        8568    8570      +2     
- Misses      4206    4212      +6     
+ Partials     263     262      -1     
Files with missing lines Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 96.6% <0.0%> (-3.4%) ⬇️
...entation/google.golang.org/grpc/otelgrpc/config.go 85.8% <0.0%> (-4.3%) ⬇️

... and 1 file with indirect coverage changes