Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otellogr: Implement Info, WithName, WithValues #6111

Merged

Conversation

scorpionknifes
Copy link
Member

@scorpionknifes scorpionknifes commented Sep 12, 2024

This PR implements a few methods for otellogr package

  • Info
  • WithName
  • WithValues

Out of scope

  • Enabled
  • Init
  • Error
  • Level
    Please add skip changelog thx 🙏

Part of #5192

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 99.18699% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.8%. Comparing base (256d350) to head (9ea2723).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bridges/otellogr/convert.go 99.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6111     +/-   ##
=======================================
+ Coverage   66.4%   66.8%   +0.3%     
=======================================
  Files        205     206      +1     
  Lines      13093   13207    +114     
=======================================
+ Hits        8706    8829    +123     
+ Misses      4119    4111      -8     
+ Partials     268     267      -1     
Files with missing lines Coverage Δ
bridges/otellogr/logsink.go 98.2% <100.0%> (+18.6%) ⬆️
bridges/otellogr/convert.go 99.0% <99.0%> (ø)

... and 1 file with indirect coverage changes

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 12, 2024
bridges/otellogr/logsink.go Outdated Show resolved Hide resolved
bridges/otellogr/logsink.go Outdated Show resolved Hide resolved
bridges/otellogr/logsink_test.go Outdated Show resolved Hide resolved
bridges/otellogr/logsink_test.go Outdated Show resolved Hide resolved
bridges/otellogr/convert_test.go Outdated Show resolved Hide resolved
bridges/otellogr/logsink_test.go Outdated Show resolved Hide resolved
bridges/otellogr/logsink_test.go Outdated Show resolved Hide resolved
@scorpionknifes scorpionknifes requested a review from a team as a code owner September 19, 2024 07:46
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments left. Nice work 👍

bridges/otellogr/convert.go Outdated Show resolved Hide resolved
bridges/otellogr/convert.go Show resolved Hide resolved
@pellared pellared changed the title otellogr: Implement Logsink.Info() and conversions otellogr: Implement Info, WithName, WithValue Sep 19, 2024
@pellared pellared changed the title otellogr: Implement Info, WithName, WithValue otellogr: Implement Info, WithName, WithValues Sep 19, 2024
bridges/otellogr/convert.go Outdated Show resolved Hide resolved
bridges/otellogr/convert.go Outdated Show resolved Hide resolved
@pellared
Copy link
Member

@dmathieu, can you please take a look?

@pellared pellared merged commit ac19587 into open-telemetry:main Sep 24, 2024
25 checks passed
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants