Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support v0.3 of the config schema #6126

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

codeboten
Copy link
Contributor

Leaving this in draft until v0.3 is released.

Removing unnecessary additional Ptr funcs

Signed-off-by: Alex Boten <[email protected]>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 49.20635% with 64 lines in your changes missing coverage. Please review.

Project coverage is 65.4%. Comparing base (a6c3927) to head (8486766).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/generated_config.go 0.0% 58 Missing ⚠️
config/metric.go 86.6% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6126     +/-   ##
=======================================
- Coverage   65.7%   65.4%   -0.3%     
=======================================
  Files        204     204             
  Lines      13088   13165     +77     
=======================================
+ Hits        8608    8621     +13     
- Misses      4216    4277     +61     
- Partials     264     267      +3     
Files with missing lines Coverage Δ
config/config.go 84.0% <100.0%> (+1.7%) ⬆️
config/log.go 94.2% <100.0%> (ø)
config/resource.go 100.0% <100.0%> (ø)
config/trace.go 96.4% <100.0%> (ø)
config/metric.go 89.8% <86.6%> (-1.8%) ⬇️
config/generated_config.go 0.0% <0.0%> (ø)

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten marked this pull request as ready for review September 20, 2024 17:26
@codeboten
Copy link
Contributor Author

More go proxy sadness :(

Error: detector.go:14:2: k8s.io/[email protected]: Get "https://proxy.golang.org/k8s.io/client-go/@v/v0.31.1.zip": stream error: stream ID 5; PROTOCOL_ERROR
Error: detector.go:15:2: k8s.io/[email protected]: Get "https://proxy.golang.org/k8s.io/client-go/@v/v0.31.1.zip": stream error: stream ID 5; PROTOCOL_ERROR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant