[chore] check-clean-work-tree detects untracked files #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build should pass after #119 is merged. Now it fails as expected. See: https://github.com/open-telemetry/opentelemetry-go-instrumentation/actions/runs/4828189826/jobs/8601714742?pr=120#step:6:14 |
MrAlias
approved these changes
Apr 28, 2023
MikeGoldsmith
approved these changes
Apr 29, 2023
Co-authored-by: Mike Goldsmith <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently
check-clean-work-treedoes not detect new files created bygo generateandmake offsets.What
Use
git status --porcelainto make sure we also detect untracked files (and not only changes in tracked files).