Skip to content

Commit

Permalink
Fix the examples target info messaging (#1676)
Browse files Browse the repository at this point in the history
The echo for the target was copied from other targets that use `dir` as
an iteration variable which is not what this target uses. That means
that the empty variable `dir` is unexpanded and the unhelpful message of
"build /..." is echoed. This updates the iteration variable to match
other targets and fixes the info messaging.
  • Loading branch information
MrAlias committed Mar 8, 2021
1 parent a3aa9fd commit 76aa924
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ tools: $(CROSSLINK) $(GOLANGCI_LINT) $(MISSPELL) $(STRINGER) $(TOOLS)/gojq

.PHONY: examples generate build
examples:
@set -e; for ex in $(EXAMPLES); do \
@set -e; for dir in $(EXAMPLES); do \
echo "$(GO) build $${dir}/..."; \
(cd "$${ex}" && \
(cd "$${dir}" && \
$(GO) build .); \
done

Expand Down

0 comments on commit 76aa924

Please sign in to comment.