Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on when PR reviews should be cleared #1555

Closed
MrAlias opened this issue Feb 18, 2021 · 0 comments · Fixed by #1556
Closed

Add documentation on when PR reviews should be cleared #1555

MrAlias opened this issue Feb 18, 2021 · 0 comments · Fixed by #1556
Assignees
Labels
documentation Provides helpful information
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 18, 2021

Instead of automating the dismissal of PR reviews when changes are made to an approved PR, which can include changes like merging main into the branch, we need to get into the practice of manually clearing reviews when substantive changes are made to the PR.

To start with at least, we need to document what is expected in the CONTRIBUTING documentation.

@MrAlias MrAlias added the documentation Provides helpful information label Feb 18, 2021
@MrAlias MrAlias self-assigned this Feb 18, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants