Add docs on when reviews should be cleared

[MrAlias]

Resolves #1555

[punya]

I learned today that PR authors who aren't maintainers don't have the ability to dismiss reviews 😞 At most, they can re-request review (but any existing approvals still stand).

[Aneurysm9]

I learned today that PR authors who aren't maintainers don't have the ability to dismiss reviews 😞 At most, they can re-request review (but any existing approvals still stand).

Hmmm, does that mean we need a different approach? Do approvers have the ability to dismiss reviews or is it only maintainers?

[MrAlias]

Hmmm, does that mean we need a different approach? Do approvers have the ability to dismiss reviews or is it only maintainers?

It looks like we can explicitly set who can dismiss reviews for the repo:

Should we add OpenTelemetry members to this list? Or restrict it to go-approvers?

Also, I want to verify the statement that I made in the SIG a while ago: that the branch protection rule "Dismiss stale pull request approvals when new commits are pushed" will clear merges from the main branch. I remember this being the case when I originally tried it out, but the description of that setting ("New reviewable commits pushed to a matching branch will dismiss pull request review approvals.") makes me question this might have changed.

[MrAlias]

I've updated to allowing the go-approvers to dismiss reviews. I could not figure out how to have the interface allow all members of the org to dismiss reviews (it would not auto-complete a selection).