Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Doc links to PeriodicReader after release #4448

Closed
MadVikingGod opened this issue Aug 15, 2023 · 2 comments
Closed

Update Doc links to PeriodicReader after release #4448

MadVikingGod opened this issue Aug 15, 2023 · 2 comments
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information pkg:exporter:otlp Related to the OTLP exporter package

Comments

@MadVikingGod
Copy link
Contributor

Currently there are documentation references to PeriodicReaders in [otlpmetrichttp] and [oltpmetricgrpc], but because the PeriodicReaders have not been released we can't make a live link to them in the go docs.

After the v0.40 release (or when PeriodicReaders are released) update these docs to reflect the current status.

Originally posted by @pellared in #4336 (comment)
@MadVikingGod MadVikingGod added documentation Provides helpful information area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Aug 15, 2023
@MadVikingGod MadVikingGod mentioned this issue Aug 15, 2023
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Aug 15, 2023 •
edited
Loading

You should be able to link prior to the release. You can use https://pkg.go.dev/golang.org/x/pkgsite to verify the links will correctly render.

Ah, never mind. I see the links are in a markdown file.

@pellared
Copy link
Member

pellared commented Nov 2, 2023

It will be addressed as part of #4688

@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
Go: Metric OTLP Exporter (GA)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadVikingGod @pellared @MrAlias