otlpmetricgrpc otlpmetrichttp: Add README.md #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
added
documentation
MadVikingGod
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
dmathieu
reviewed
Jul 18, 2023
pellared
reviewed
Jul 18, 2023
Removed the unified readme. Added make target to lint markdown locally.
|
The filename is in lowercase, while every other readme in the repo is uppercase. |
pellared
approved these changes
Jul 19, 2023
hanyuancheung
approved these changes
Aug 21, 2023
dmathieu
approved these changes
Aug 23, 2023
pellared
requested changes
Sep 6, 2023
pellared
reviewed
Sep 6, 2023
Co-authored-by: Robert Pająk <[email protected]>
Yes, I have not included any of the Trace environment variables in the Metrics documentation PR. |
pellared
approved these changes
Oct 3, 2023
pellared
reviewed
Oct 27, 2023
|
@MadVikingGod PTAL, I did my best to update this PR. |
dashpole
reviewed
Oct 27, 2023
pellared
reviewed
Oct 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #4336 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 225 225
Lines 18044 18044
=====================================
+ Hits 14750 14752 +2
+ Misses 2996 2994 -2
Partials 298 298 |
pellared
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at adding a readme to the otlpmetric exporter.
It is mostly a copy of the otlptrace readme. The attempt is to make this look presentable in github's markdown, and in pkg.go.dev.