-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The default endpoint should use HTTP, not HTTPS #4834
Comments
Most people is not everyone. For some it would be a breaking change. This issue was already discussed at least 2 times during SIG meetings and nobody was supporting such change. There is a more detailed explanation in the issue that you mentioned. |
Is there a policy for making breaking changes? It seems that when a single component in a whole ecosystem deviates from the rest of the ecosystem, by making it conform we will benefit not just this single component, but the whole ecosystem and its users in the long run, even if it involves making a breaking change.
I've read it all, but I believe it is based on a false premise, which I've explained in #4834 (comment). Could you please clarify this? |
Thanks! So according to VERSIONING.md, it seems that the change proposed here falls under the following statement:
Could this change be scheduled for |
Right now, I do not see any |
Closing as, according to my knowledge, the SIG is against creating a |
This seems to put the go sdk out of compliance with the spec. If this isn't reverted I encourage documentation at https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/otlp/otlptrace/otlptracehttp/doc.go#L12 to be updated to point out that the default value for the go SDK is non-standard. |
The default value is already documented on your link. |
Do you acknowledge that this diverges from the spec and that is harms developer experience? |
This does diverge from the spec. It would also, again be argued that configuration should be secure by default (and therefore default to HTTPS). So if we start looking at a major release, I'd favor changing the spec rather than this implementation. |
Here's an excerpt from the OpenTelemetry's mission statement:
Now take a look at the following table:
http://localhost:PORT
endpoint by defaultI've searched for the issues a bit and found #4147 (comment), which argues against the change, saying that:
However, I believe it is based on a false premise that we need treat all
OTEL_EXPORTER_OTLP_ENDPOINT
's as HTTP by default.What we need instead is to simply change the default
OTEL_EXPORTER_OTLP_ENDPOINT
value fromhttps://localhost:PORT
tohttp://localhost:PORT
.Moreover, I'd strongly argue that most people won't notice this change at all, because almost everyone seems to run the OpenTelemetry Collector with the TLS disabled.
Cc: @pellared
The text was updated successfully, but these errors were encountered: