Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trace API TracerOption #1109

Merged
merged 5 commits into from
Sep 2, 2020
Merged

Update trace API TracerOption #1109

merged 5 commits into from
Sep 2, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 28, 2020

Update the TracerOption to conform to project options standards.

Part of #536

@MrAlias
Update Tracer configuration.
96eac89 
Conform to API option design outlined in #536.

Add tests to validate new TracerConfigure function

Drop the `instrumentation` prefix.
@MrAlias
Stick with instrumentationVersion for now
3f6b233
@MrAlias
Propagate changes
e33f6fe
@MrAlias MrAlias added pkg:API Related to an API package area:trace Part of OpenTelemetry tracing release:required-for-ga labels Aug 28, 2020
@MrAlias MrAlias self-assigned this Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #1109 into master will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1109    +/-   ##
=======================================
  Coverage    77.1%   77.1%            
=======================================
  Files         133     132     -1     
  Lines        7108    6995   -113     
=======================================
- Hits         5483    5396    -87     
+ Misses       1373    1355    -18     
+ Partials      252     244     -8
Impacted Files Coverage Δ
api/trace/api.go 63.6% <100.0%> (+9.6%) ⬆️
api/trace/tracetest/provider.go 100.0% <100.0%> (+9.5%) ⬆️
sdk/trace/provider.go 85.5% <100.0%> (-0.4%) ⬇️
exporters/trace/jaeger/agent.go 43.7% <0.0%> (-14.4%) ⬇️
api/trace/tracetest/mock_tracer.go
exporters/trace/jaeger/reconnecting_udp_client.go
api/trace/tracetest/mock_span.go
internal/trace/mock_tracer.go 59.0% <0.0%> (ø)
internal/trace/mock_span.go 10.0% <0.0%> (ø)
exporters/trace/jaeger/uploader.go 59.3% <0.0%> (+5.9%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review August 28, 2020 18:34
@MrAlias MrAlias requested a review from XSAM as a code owner September 1, 2020 22:21
XSAM
XSAM approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit 0fec280 into open-telemetry:master Sep 2, 2020
@MrAlias MrAlias deleted the tracer-config branch September 2, 2020 14:20
evantorrie pushed a commit to evantorrie/opentelemetry-go that referenced this pull request Sep 10, 2020
@MrAlias @evantorrie
Update trace API TracerOption (open-telemetry#1109)
2fe8b57 
* Update Tracer configuration.

Conform to API option design outlined in open-telemetry#536.

Add tests to validate new TracerConfigure function

Drop the `instrumentation` prefix.

* Stick with instrumentationVersion for now

* Propagate changes

* Add changes to Changelog
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XSAM XSAM XSAM approved these changes

@jmacd jmacd jmacd approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees

@MrAlias MrAlias

Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @jmacd @XSAM @pellared