Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Span Event to API #1452

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Move Span Event to API #1452

merged 4 commits into from
Jan 14, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 13, 2021

Span events are an API concern. This moves the Event type from the SDK export package to the API.

Related to #1380

@MrAlias MrAlias added pkg:API Related to an API package area:trace Part of OpenTelemetry tracing release:required-for-ga labels Jan 13, 2021
@MrAlias MrAlias added this to the RC1 milestone Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1452 (1eadee7) into master (4392224) will not change coverage.
The diff coverage is 80.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1452   +/-   ##
======================================
  Coverage    78.9%   78.9%           
======================================
  Files         128     128           
  Lines        6672    6672           
======================================
  Hits         5269    5269           
  Misses       1148    1148           
  Partials      255     255           
Impacted Files Coverage Δ
exporters/otlp/internal/transform/span.go 98.0% <ø> (ø)
exporters/trace/zipkin/model.go 98.6% <ø> (ø)
trace/trace.go 86.6% <ø> (ø)
sdk/trace/span.go 91.4% <75.0%> (ø)
exporters/otlp/internal/otlptest/data.go 61.7% <100.0%> (ø)

@MrAlias MrAlias merged commit fe363be into open-telemetry:master Jan 14, 2021
@MrAlias MrAlias deleted the span-event branch January 14, 2021 17:07
@MrAlias MrAlias mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants