-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TracerProvider tests to oteltest harness #1607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
February 26, 2021 00:46
Codecov Report
@@ Coverage Diff @@
## main #1607 +/- ##
=======================================
- Coverage 77.6% 77.2% -0.4%
=======================================
Files 128 128
Lines 6637 6669 +32
=======================================
Hits 5155 5155
- Misses 1235 1267 +32
Partials 247 247
|
Aneurysm9
approved these changes
Feb 26, 2021
jmacd
approved these changes
Mar 2, 2021
XSAM
approved these changes
Mar 3, 2021
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Add TracerProvider tests to oteltest harness * Update Tracer method docs * Fix grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:testing
Related to testing or a testing package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1587
Ensure our
TracerProvider.Tracer
method is safe to call concurrently and that multipleTracerProviders
can be created as required by the specification.