Update the SimpleSpanProcessor #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subsequent calls to OnStart, OnEnd, and ForceFlush should be ignored gracefully once Shutdown has been called. This implements that behavior by shutting down the exporter and removing it from the SimpleSpanProcessor so subsequent calls to OnEnd will be no-ops.
MrAlias
requested review from
Aneurysm9,
dashpole and
evantorrie
as code owners
seh
reviewed
Feb 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #1612 +/- ##
=====================================
Coverage 77.3% 77.4%
=====================================
Files 128 128
Lines 6694 6705 +11
=====================================
+ Hits 5179 5190 +11
Misses 1268 1268
Partials 247 247
|
MrAlias
commented
Feb 26, 2021
4 tasks
seh
reviewed
Feb 26, 2021
Co-authored-by: Steven E. Harris <[email protected]>
jmacd
reviewed
Mar 2, 2021
XSAM
approved these changes
Mar 4, 2021
revert comment change from merge
Aneurysm9
approved these changes
Mar 5, 2021
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
> Shutdown SHOULD be called only once for each SpanProcessor instance. After the call to Shutdown, subsequent calls to OnStart, OnEnd, or ForceFlush are not allowed. SDKs SHOULD ignore these calls gracefully, if possible.
This implements that behavior by shutting down the exporter and removing it from the SimpleSpanProcessor so subsequent calls to OnEnd will be no-ops.