-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger Exporter: Fix minor mapping discrepancies #1626
Jaeger Exporter: Fix minor mapping discrepancies #1626
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1626 +/- ##
=====================================
Coverage 77.3% 77.3%
=====================================
Files 128 128
Lines 6682 6693 +11
=====================================
+ Hits 5167 5180 +13
+ Misses 1268 1266 -2
Partials 247 247
|
@matej-g TagInstrumentationName = "otlp.instrumentation.library.name"
TagInstrumentationVersion = "otlp.instrumentation.library.version" |
Not sure what the requirements are for the collector, but as it stands in the specification, I believe |
The specification for Jaeger exporter specifies a number of requirements on how the span data should be mapped between OpenTelemetry and Jaeger.
This PR intends to correct some minor discrepancies which have been found previously, in particular:
otel.library.*
instead ofotel.instrumentation_library.*
(relevant section)SpanKind.INTERNAL
should not be added to tags (relevant section).UNSET
(relevant section).FOLLOWS_FROM
(relevant section).Includes also test changes.
Related issue
One aspect that remain unclear to me, which is not addressed in this PR, I have described in #1625
Resolves (partially) #1376.