Remove WithRecord() option from trace.SpanOption when starting a span #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the trace API into conformance with the specification.
evantorrie
requested review from
Aneurysm9,
dashpole,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
=====================================
Coverage 77.2% 77.2%
=====================================
Files 128 128
Lines 6799 6788 -11
=====================================
- Hits 5254 5246 -8
+ Misses 1294 1291 -3
Partials 251 251
|
Aneurysm9
approved these changes
Mar 5, 2021
XSAM
approved these changes
Mar 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
This PR simply removes the
WithRecord()option completely.Decisions on whether a span will record events are currently left in the purview of the Sampler at initial Span creation time.
For future reference, there are unresolved OTEPs and specification issues which may influence the design of Span recording/sampling.
See open-telemetry/oteps#115 and open-telemetry/opentelemetry-specification#307.