Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush metric events prior to shutdown in OTLP example #1678

Merged
merged 5 commits into from
Mar 10, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 8, 2021

Resolves #1499

@MrAlias MrAlias added the bug Something isn't working label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1678 (7c7df76) into main (66b1135) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1678   +/-   ##
=====================================
  Coverage   77.2%   77.2%           
=====================================
  Files        128     128           
  Lines       6788    6788           
=====================================
+ Hits        5244    5246    +2     
+ Misses      1293    1291    -2     
  Partials     251     251           
Impacted Files Coverage Δ
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias merged commit 9c305bd into open-telemetry:main Mar 10, 2021
@MrAlias MrAlias deleted the fix-1499 branch March 10, 2021 16:20
@MrAlias MrAlias mentioned this pull request Mar 18, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter is shutdown before controller finishes pushing metric events in otel-collector example
4 participants