Fix issue #1490, apply same logic as in the SDK #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1687 +/- ##
=====================================
Coverage 77.3% 77.3%
=====================================
Files 128 128
Lines 6787 6796 +9
=====================================
+ Hits 5247 5256 +9
Misses 1290 1290
Partials 250 250
|
bogdandrutu
force-pushed
the
fixmemory
branch
3 times, most recently
from
f53c476
to
4922f43
Compare
jmacd
approved these changes
Mar 10, 2021
Aneurysm9
approved these changes
Mar 10, 2021
MrAlias
reviewed
Mar 10, 2021
MrAlias
approved these changes
Mar 10, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1490