Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename leftover references to SpanData #1736

Closed
wants to merge 2 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 26, 2021

Part of clean identified needed in #1380

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #1736 (09a13a6) into main (382c7ce) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1736   +/-   ##
=====================================
  Coverage   77.9%   78.0%           
=====================================
  Files        131     131           
  Lines       6953    6953           
=====================================
+ Hits        5422    5424    +2     
+ Misses      1281    1279    -2     
  Partials     250     250           
Impacted Files Coverage Δ
exporters/otlp/internal/transform/span.go 98.1% <ø> (ø)
exporters/otlp/otlpgrpc/driver.go 90.1% <100.0%> (ø)
exporters/otlp/otlphttp/driver.go 93.8% <100.0%> (ø)
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (+1.8%) ⬆️

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 26, 2021

The overall direction of that issues is to eventually move away from SpanSnapshot anyway. This will become wasted work. Closing.

@MrAlias MrAlias closed this Mar 26, 2021
@MrAlias MrAlias deleted the rename-spandata branch March 26, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants