Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include authentication information in the http.url attribute #1919

Merged
merged 2 commits into from
May 13, 2021

Conversation

Aneurysm9
Copy link
Member

Fixes #1675

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1919 (34192ba) into main (d8ac212) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1919     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        139     139             
  Lines       7449    7452      +3     
=======================================
+ Hits        5918    5919      +1     
- Misses      1283    1285      +2     
  Partials     248     248             
Impacted Files Coverage Δ
semconv/http.go 95.3% <100.0%> (+0.1%) ⬆️
exporters/trace/jaeger/jaeger.go 93.4% <0.0%> (-1.1%) ⬇️

@Aneurysm9 Aneurysm9 merged commit 035fc65 into open-telemetry:main May 13, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Span Attributes: http.url must not contain username / password
6 participants