-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated Processor interface and moved to own package #2326
Deprecated Processor interface and moved to own package #2326
Conversation
Help speed up development of metrics SDK for Go
7196452
to
497ecba
Compare
Codecov Report
@@ Coverage Diff @@
## main #2326 +/- ##
=======================================
- Coverage 73.6% 73.6% -0.1%
=======================================
Files 175 175
Lines 12409 12409
=======================================
- Hits 9137 9134 -3
- Misses 3039 3041 +2
- Partials 233 234 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this change set looks good. Only minor issues to address.
@@ -401,7 +401,6 @@ github.com/imdario/mergo v0.3.12 h1:b6R2BslTbIEToALKP7LxUvijTsNI9TAe80pLWN2g/HU= | |||
github.com/imdario/mergo v0.3.12/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA= | |||
github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NHg9XEKhtSvM= | |||
github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8= | |||
github.com/itchyny/go-flags v1.5.0 h1:Z5q2ist2sfDjDlExVPBrMqlsEDxDR2h4zuOElB0OEYI= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this change? It looks like it is reverting #2316.
I'm guessing the tooling automatically did this and we should look into not having it clear this.
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
@jmacd I've notice and issue is doing via smaller deprecations means doing an odd alias back to package I am trying to deprecate. As much as I thought it made sense to do smaller cuts and deprecations, I think it has to be done within the one change in order to avoid situations are trying to alias the would be deprecated package in the packages the types are moving to. I am gonna close off the smaller PRs and do it in one clean sweep |
Helping contribute to #2273