Add env support for span limits configuration #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cuichen Li <[email protected]>
cuichenli
changed the title
cuichenli
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod and
pellared
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2606 +/- ##
=====================================
Coverage 76.2% 76.2%
=====================================
Files 173 173
Lines 12234 12239 +5
=====================================
+ Hits 9324 9329 +5
Misses 2667 2667
Partials 243 243
|
Aneurysm9
reviewed
Feb 14, 2022
|
Hi @Aneurysm9 , I have updated the code based on the above comments. Please take a look again. Thanks! |
Aneurysm9
approved these changes
Feb 15, 2022
Co-authored-by: Anthony Mirabella <[email protected]>
pellared
reviewed
Feb 15, 2022
MadVikingGod
approved these changes
Feb 15, 2022
MrAlias
requested changes
Feb 16, 2022
Signed-off-by: Cuichen Li <[email protected]>
Signed-off-by: Cuichen Li <[email protected]>
pellared
approved these changes
Feb 16, 2022
MrAlias
reviewed
Feb 16, 2022
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
reviewed
Feb 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2307