Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update corrupted dependency golangci-lint #2761

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Update corrupted dependency golangci-lint #2761

merged 2 commits into from
Apr 1, 2022

Conversation

bradtopol
Copy link
Contributor

Signed-off-by: Brad Topol [email protected]

@bradtopol bradtopol changed the title Update corrupted dependency golangci-lint #2760 Update corrupted dependency golangci-lint Apr 1, 2022
@bradtopol
Copy link
Contributor Author

This PR addresses Issue #2760

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 1, 2022
@Aneurysm9
Copy link
Member

Please run make precommit to ensure that go.sum changes are also included.

@bradtopol
Copy link
Contributor Author

Hi @Aneurysm9 great catch! Done!

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #2761 (d2dc9c1) into main (625d76d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2761   +/-   ##
=====================================
  Coverage   76.8%   76.8%           
=====================================
  Files        181     181           
  Lines      12189   12189           
=====================================
  Hits        9363    9363           
  Misses      2601    2601           
  Partials     225     225
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (+0.9%) ⬆️

@Aneurysm9 Aneurysm9 merged commit b7a5c1a into open-telemetry:main Apr 1, 2022
@dmathieu dmathieu mentioned this pull request Apr 4, 2022
Closed
@Petrie Petrie mentioned this pull request Jun 29, 2022
Closed
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
4 participants
@bradtopol @Aneurysm9 @MrAlias @pellared