fix benchmark error, with always/never sample and add benchmark setAttribute vs setAttributes #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute vs setAttributes
paivagustavo
requested review from
jmacd,
lizthegrey,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
jmacd
approved these changes
Nov 16, 2019
|
This is unobjectionable--merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed three things with this PR.
The tracer SDK benchmarks was designed to run with 2 configs, first with
AlwaysSampleand then withNeverSamplebut it was running theAlwaysSampletwice.There was one failing benchmark, when I've changed the
TraceIDto byte array that was expecting the wrongTraceID, my bad.Also, I've added a benchmark with a hot discussion about variadic functions vs singular functions (e.g., setAttribute vs setAttributes) so we can take better discussion about the pros and cons of each alternative. (see Remove Span.SetAttribute #302, Suggestion: Add WithAttribute option #310, and Suggestion re: span start/end option naming #197)