Fix the defaultkeys metrics batcher #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
lizthegrey,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
lizthegrey
approved these changes
Nov 19, 2019
Merged
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
…333) * Update utils README * Update comments in utils module * Update comments in example module * Update example module README * Update project README * Add supported properties to utils submodule README * Add authentication section to project README * Add Table of Contents * Add aggregation mapping section and update table of contents * Add error handling and retry logic sections and update toc * Update retry logic section of project README * Clarify code snippet comment in project README * Add Installation section and update TOC * Correct installation link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "defaultkeys" batcher was using only the encoded label set as its map key while building a checkpoint. This allowed distinct label sets through, but any metrics sharing a label set could be overwritten or merged incorrectly.
h/t @lizthegrey