Add Metric Producer as a new interface, which returns scope metrics #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers: looking for high-level feedback on interface design here. |
dashpole
force-pushed
the
other_metricproducer
branch
from
a88a52e
to
8631d4e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
=======================================
+ Coverage 77.9% 78.0% +0.1%
=======================================
Files 164 164
Lines 11703 11762 +59
=======================================
+ Hits 9123 9182 +59
Misses 2385 2385
Partials 195 195
|
dashpole
force-pushed
the
other_metricproducer
branch
from
8631d4e
to
8a0d68b
Compare
dashpole
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
This is now ready for review. |
dashpole
changed the title
MrAlias
approved these changes
Dec 9, 2022
Co-authored-by: Tyler Yahn <[email protected]>
3 tasks
2 tasks
jmacd
approved these changes
Dec 12, 2022
fatsheep9146
approved these changes
Dec 12, 2022
hanyuancheung
approved these changes
Dec 14, 2022
MrAlias
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3504
Implements open-telemetry/opentelemetry-specification#2951.
This adds metric.Producer as an additional interface beyond the current producer interface used for the SDK. It has the advantage of scoping metrics from the Producer to only ScopeMetrics, instead of ResourceMetrics.
As an alternative, I explored #3523, which would re-use the existing
producerinterface, and make it shared by the SDK and bridge implementations.