Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using OTLP export retrier concurrently #3756

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Allow using OTLP export retrier concurrently #3756

merged 3 commits into from
Feb 21, 2023

Conversation

dmathieu
Copy link
Member

This change allows calling the OTLP retrier concurrently, so it can be used with several tracer providers.

Example:

exporter, _ := otlptrace.New(ctx, otlptracegrpc.NewClient())
tp1 := otelsdktrace.NewTracerProvider(otelsdktrace.WithBatcher(exporter))
tp2 := otelsdktrace.NewTracerProvider(otelsdktrace.WithBatcher(exporter))

Closes #3755

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #3756 (001981d) into main (de94faf) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3756   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        166     166           
  Lines      12432   12435    +3     
=====================================
+ Hits       10152   10157    +5     
+ Misses      2065    2063    -2     
  Partials     215     215           
Impacted Files Coverage Δ
exporters/otlp/internal/retry/retry.go 98.3% <100.0%> (+<0.1%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple NewTracerProvider calls with the same batcher cause data race
5 participants