Add decision about v2 API #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
added
the
Skip Changelog
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
dmathieu
reviewed
Apr 4, 2023
Aneurysm9
approved these changes
Apr 4, 2023
pellared
approved these changes
Apr 4, 2023
hanyuancheung
approved these changes
Apr 6, 2023
|
I believe this also closes #3277 |
mx-psi
reviewed
Apr 10, 2023
Co-authored-by: Damien Mathieu <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3968 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 181 181
Lines 14115 14115
=====================================
Hits 11783 11783
Misses 2105 2105
Partials 227 227 |
|
@open-telemetry/go-maintainers Can you please double-check? I am leaning towards merging this PR. |
mx-psi
approved these changes
Jun 1, 2023
|
Waiting a week before merging. |
dmathieu
approved these changes
Jun 1, 2023
seh
reviewed
Jun 1, 2023
Co-authored-by: Steven E. Harris <[email protected]>
seh
reviewed
Jun 1, 2023
Co-authored-by: Steven E. Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves a record in our document about the findings of V2, and how we won't use a v2.
Closes: #3920
This does add procedural language about how updates around an API change will happen. These are my suggestion, and I am open to a different approach.