[chore] Rebuild .tools as they can be outdated #5220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
MrAlias
reviewed
Apr 17, 2024
MrAlias
reviewed
Apr 18, 2024
MrAlias
approved these changes
Apr 18, 2024
XSAM
approved these changes
Apr 18, 2024
This was referenced May 15, 2024
pellared
added a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
May 20, 2024
khushijain21
pushed a commit
to khushijain21/opentelemetry-go-contrib
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I find it annoying that the target for tools are only build once and it easy to get the tooling outdated locally and have different results than on CI.
What
internal/tools/go.modas a normal prerequisite for tools so that they are rebuild oncego.modchanges. I want to point out thatgo.modis touched each timego mod tidyis executed so often the tools will be rebuild when people usemake. Rebuilding the tools thanks to the go build cache takes only a few seconds. If one e.g. just runsmake golangci-linta few times then the tools will not be rebuild.internal/tools/go.modas otherwise all build tools would be rebuild; e.g.: https://github.com/open-telemetry/opentelemetry-go/actions/runs/8717700613/job/23913426182 (related thread: [chore] Rebuild .tools as they can be outdated #5220 (comment)). More: https://stackoverflow.com/a/55609950/859275More: https://www.gnu.org/software/make/manual/make.html#index-order_002donly-prerequisites
Alternative
This PR looks to me more "Make idiomatic", but the alternative approach is simpler: