Move SpanContext from core package into trace #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensorchen
requested review from
Aneurysm9,
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
Aneurysm9
approved these changes
May 2, 2020
There was a problem hiding this comment.
These changes look good to me, though they are BC breaking and will have impact on exporters and contrib modules that live outside this repo. We should communicate loudly and widely that we are making this change before merging to allow time for dependents to prepare.
tensorchen
force-pushed
the
move_span_context
branch
from
3c7718f
to
5b156e4
Compare
tensorchen
force-pushed
the
move_span_context
branch
from
5b156e4
to
bae2298
Compare
jmacd
approved these changes
May 4, 2020
|
To @Aneurysm9's point, I believe we have to communicate these changes before we make a release, not before we merge. This looks good to merge, to me. |
jmacd
approved these changes
May 4, 2020
MrAlias
reviewed
May 4, 2020
lizthegrey
approved these changes
May 5, 2020
MrAlias
approved these changes
May 5, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #275