Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting span status to Unknown when no HTTP status is provided;… #908

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Avoid setting span status to Unknown when no HTTP status is provided;… #908

merged 2 commits into from
Jul 7, 2020

Conversation

Aneurysm9
Copy link
Member

… stdlib assumes it to be 200 OK

Fixes #897

@Aneurysm9 Aneurysm9 mentioned this pull request Jul 7, 2020
Closed
MrAlias
MrAlias approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrAlias MrAlias merged commit eaa94e9 into open-telemetry:master Jul 7, 2020
@Aneurysm9 Aneurysm9 deleted the OTG-897 branch July 7, 2020 20:00
@MrAlias MrAlias mentioned this pull request Jul 9, 2020
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd jmacd approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Invalid HTTP status code 0
4 participants
@Aneurysm9 @jmacd @MrAlias @pellared