stop detecting cloud providers early #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfinnigan
reviewed
Mar 13, 2024
gcp-resources/src/main/java/io/opentelemetry/contrib/gcp/resource/GCPResourceProvider.java
Show resolved
Hide resolved
kenfinnigan
approved these changes
Mar 14, 2024
breedx-splk
reviewed
Mar 27, 2024
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/CloudResourceProvider.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Mar 27, 2024
psx95
approved these changes
Apr 24, 2024
trask
reviewed
Apr 24, 2024
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/CloudResourceProvider.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
avoid-multiple-cloud-resource-providers
branch
from
95197f7
to
8db984e
Compare
|
@trask please check again |
…rce/CloudResourceProvider.java Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop detecting cloud providers once a provider has successfully detected a cloud provider