Disable by default metrics and logs #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfinnigan
approved these changes
Apr 16, 2024
trask
approved these changes
Apr 16, 2024
|
@cyrille-leclerc ok to mark this ready to review and merge? |
I would like to get @XN137 's answer to #1227 (comment) |
|
I didn't reproduce the problem encountered in #1227 but this PR is relevant so I mark it as ready for review. |
kenfinnigan
approved these changes
May 2, 2024
breedx-splk
approved these changes
May 6, 2024
|
@cyrille-leclerc Approvals are in place. Please ping us when you're at a happy point with #1227. |
|
Sorry for the delay. We can merge this PR that is needed to handle evolutions of the OTel SDKs since this area of code of the OTel Maven Extension was written. #1227 may be a slightly different problem, I'm continuing to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Disable by default metrics and logs as there are now enabled by default.
Existing Issue(s):
WARNING: Failed to export metricswhen disabled #1227Testing:
There is unfortunately no testing framework for Maven extensions.
Documentation:
TODO, verification in progress
Outstanding items:
None