Use service.name resource attribute instead of span name for service … #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Nov 24, 2021
anuraaga
force-pushed
the
xray-servicename
branch
from
ba023cf
to
a587a72
Compare
laurit
approved these changes
Nov 24, 2021
willarmiros
approved these changes
Nov 24, 2021
| @@ -175,7 +175,7 @@ boolean matches(String name, Attributes attributes, Resource resource) { | |||
| } | |||
|
|
|||
| return urlPathMatcher.matches(httpTarget) | |||
There was a problem hiding this comment.
What about updating this matcher to HTTP URL instead of target? Separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had misinterpreted the span name being more appropriate, remembering the transformation we do in the collector's xray exporter, but it should indeed by service name when sampling within OTel.