Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Tomcat #155

Merged
merged 10 commits into from
Jan 5, 2022
Merged

Add Support for Tomcat #155

merged 10 commits into from
Jan 5, 2022

Conversation

Mrod1598
Copy link
Contributor

Description:

< Describe what is being changed or added.
Add Tomcat Support.

Testing:
Added Tomcat Int test

Documentation:
Added doc for tomcat

@Mrod1598 Mrod1598 requested a review from a team December 17, 2021 15:57
@Mrod1598
Copy link
Contributor Author

Mrod1598 commented Jan 3, 2022

@rmfitzpatrick Hello! I was wondering if you had time to take a look at this PR to add support for tomcat? I'd really appreciate it. Thanks!

@rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick Hello! I was wondering if you had time to take a look at this PR to add support for tomcat? I'd really appreciate it. Thanks!

Sorry for the delay, I've been afk for some time. This looks good to me with a couple requests, thanks.

@rmfitzpatrick rmfitzpatrick merged commit b7e290b into open-telemetry:main Jan 5, 2022
@Mrod1598 Mrod1598 deleted the tomcat branch January 20, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants