Update Kafka JMX Script #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Jan 26, 2022
| @@ -28,6 +30,29 @@ | |||
| import org.testcontainers.utility.MountableFile; | |||
|
|
|||
| abstract class KafkaIntegrationTest extends AbstractIntegrationTest { | |||
| Startable createTopics = | |||
There was a problem hiding this comment.
Any reason for moving this? Previously the containers were listed in order of execution which was a bit nicer
There was a problem hiding this comment.
Nope. I had moved it initially when I was trying to leverage it for another container but ended up removing that and didn't move it back. Will resolve.
| @@ -112,8 +112,8 @@ void beforeEach() { | |||
| otlpServer.reset(); | |||
| } | |||
|
|
|||
| @SafeVarargs | |||
| protected final void waitAndAssertMetrics(Consumer<Metric>... assertions) { | |||
| @SuppressWarnings("varargs") | |||
There was a problem hiding this comment.
Don't think I see a varargs usage in this method
anuraaga
approved these changes
Jan 27, 2022
Merged in the changes, looks like everything is passing, can I get a re-review @rmfitzpatrick ? |
rmfitzpatrick
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Update Kafka JMX metrics to update names, units, fix counters, and get more metrics.
Testing: Updated Integration test