Fix "Class path contains multiple SLF4J bindings" during runtime atta… #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Jul 6, 2022
runtime-attach-distro/src/main/java/io/opentelemetry/contrib/attach/AgentFileProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <[email protected]>
Changes done |
trask
reviewed
Jul 7, 2022
runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/AgentFileProvider.java
Show resolved
Hide resolved
|
I have just realized that it may be possible to simplify the implementation with the uber jar (the temporary folder might become unecessary). Please let me check before continuing the review. |
My idea to simplify the implementation does not work. Please continue the review. |
mateuszrzeszutek
approved these changes
Jul 8, 2022
|
thx! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a "Class path contains multiple SLF4J bindings" warning during runtime attachment.
The agent jar file is no longer added to the classpath. Now, it is included in the runtime attach artifact.
A project dedicated to providers of the OpenTelemetry Java agent is added. It can help them to build a dependency to runtime attach their agent jar file.