Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no Class in opentelemetry-runtime-attach jar #509

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix no Class in opentelemetry-runtime-attach jar #509

merged 1 commit into from
Oct 11, 2022

Conversation

jeanbisutti
Copy link
Member

Fix #508

@jeanbisutti jeanbisutti requested a review from a team October 11, 2022 09:34
@github-actions github-actions bot requested a review from iNikem October 11, 2022 09:34
trask
trask approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added topic to Thu SIG meeting to discuss moving runtime-attach artifact over to instrumentation repo so we can use the smoke-test infra over there to catch this kind of issue

@trask trask merged commit 3170891 into open-telemetry:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@iNikem iNikem Awaiting requested review from iNikem

Assignees

@iNikem iNikem

@jeanbisutti jeanbisutti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Class in opentelemetry-runtime-attach jar
3 participants
@jeanbisutti @trask @iNikem