Glassfish service name detector #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Nov 10, 2022
trask
reviewed
Nov 15, 2022
Sure, I assume you want it in this module README or did you have something else in mind? |
👍 |
|
thx @breedx-splk! |
trask
pushed a commit
that referenced
this pull request
Nov 16, 2022
This builds on #579 (and will be rebased when that merges). It adds the remaining service name detectors for various app servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #562 that introduces the first of several web app servers for which we will detect the service name.
Because this is the first (GlassFish), it includes some of the helper/plumbing utilities. Subsequent additions will mostly be the
AppServerimplementations (and adding them to the delegate list).