Add log appender example #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Mar 1, 2023
Comment on lines
+28
to
+31
| private static final org.apache.logging.log4j.Logger log4jLogger = | ||
| LogManager.getLogger("log4j-logger"); | ||
| private static final org.slf4j.Logger slf4jLogger = LoggerFactory.getLogger("slf4j-logger"); | ||
| private static final java.util.logging.Logger julLogger = Logger.getLogger("jul-logger"); |
There was a problem hiding this comment.
😱 (to seem them used all in one file 😂)
There was a problem hiding this comment.
Ha, originally I had separate examples for each situation, but that just created a bunch of bloat and increased the maintenance burden. Let's show it all in one place instead!
log-appender/src/main/java/io/opentelemetry/example/logappender/Application.java
Outdated
Show resolved
Hide resolved
…r/Application.java Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functional examples demonstrating the log4j and logback appenders.
Partially motivated by the goal of stabilizing log bridge API and SDK, partially to make it abundantly how to use our log solutions.