Fix lettuce latest dep tests #12552
Merged
Fix lettuce latest dep tests #12552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Nov 1, 2024
| protected static List<AttributeAssertion> addExtraAttributes(AttributeAssertion... assertions) { | ||
| List<AttributeAssertion> result = new ArrayList<>(Arrays.asList(assertions)); | ||
| if (Boolean.getBoolean("testLatestDeps")) { | ||
| result.add(equalTo(DbIncubatingAttributes.DB_NAMESPACE, "0")); |
There was a problem hiding this comment.
@trask we use lettuce built in tracing and that uses db.namespace, should we map it to db.name when using old semconv? This attribute is only generated by the latest lettuce.
jaydeluca
approved these changes
Nov 1, 2024
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12550
Resolves #12551