Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memleak in the Netty ChannelPipeline instrumentation #4053

Conversation

mateuszrzeszutek
Copy link
Member

Hopefully that should resolve #4040

@@ -109,4 +112,20 @@ public static void removeHandler(
}
}
}

@SuppressWarnings("unused")
public static class RemoveFirstLastAdvice {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions about the handling of removelast, if user call removelast here, maybe the handler be removed will be ourHander? And the origin handler will be remained if user only call removelast once.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're exactly right - I'll create a separate issue for this, since it has never worked correctly.
Thanks!

@trask trask merged commit 23fc4ce into open-telemetry:main Sep 7, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the fix-netty-channelPipeline-memleak branch November 18, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seemed that there is a memory leak in spring cloud gateway.(instrumentation version release.1.4.0)
4 participants