Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an overload to the recordException method to support additional attributes #1599

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

dengliming
Copy link
Member

closes #1597

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1599 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1599   +/-   ##
=========================================
  Coverage     91.56%   91.56%           
- Complexity      985      988    +3     
=========================================
  Files           117      117           
  Lines          3603     3606    +3     
  Branches        314      315    +1     
=========================================
+ Hits           3299     3302    +3     
  Misses          208      208           
  Partials         96       96           
Impacted Files Coverage Δ Complexity Δ
api/src/main/java/io/opentelemetry/trace/Span.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../main/java/io/opentelemetry/trace/DefaultSpan.java 80.76% <100.00%> (+0.76%) 19.00 <1.00> (+1.00)
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 81.89% <100.00%> (+0.15%) 78.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac7193...214356e. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkwatson
Copy link
Contributor

one small simplification, and this will be good to go. Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an overload to the recordException method to support additional attributes
5 participants