-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an overload to the recordException method to support additional attributes #1599
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
=========================================
Coverage 91.56% 91.56%
- Complexity 985 988 +3
=========================================
Files 117 117
Lines 3603 3606 +3
Branches 314 315 +1
=========================================
+ Hits 3299 3302 +3
Misses 208 208
Partials 96 96
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/RecordEventsReadableSpan.java
Outdated
Show resolved
Hide resolved
one small simplification, and this will be good to go. Thanks for picking this up! |
closes #1597