Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new tedious version 16 #1656

Closed
blumamir opened this issue Aug 29, 2023 · 6 comments · Fixed by #2178 or #2211
Closed

Support new tedious version 16 #1656

blumamir opened this issue Aug 29, 2023 · 6 comments · Fixed by #2178 or #2211
Assignees
@david-luna
Labels
never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@blumamir
Copy link
Member

Tedious current latest major is 16.
Since tedious 16 dropped support for node 14, it makes our CI fail currently.

I attempted to fix that in #1638 in few ways, but they all were dead ends. I am unable to run tests locally as mssql has no docker image version for my Mac Apple chip which means I cannot run tests locally. After a few failed attempts to fix the test via the CI, I decided it was too much for me currently so I documented the task in this issue instead.
This was referenced Aug 29, 2023
Closed
Closed
@blumamir blumamir added up-for-grabs Good for taking. Extra help will be provided by maintainers never-stale labels Aug 29, 2023
@mderriey
Copy link

mderriey commented Mar 4, 2024

Hey @blumamir, thanks for opening this.

We just upgraded tedious to 16.7.1 and realised that the current instrumentation supports the >=1.11.0 <=15 version range.

I saw you tried to support v16 in the PRs mentioned above.
Is there anything I can do to help? I have a Windows machine so the SQL Server image shouldn't be an issue.

Cheers.

@trentm trentm mentioned this issue Apr 23, 2024
Merged
@david-luna
Copy link
Contributor

@blumamir @mderriey

I can take this one after #2144 gets merged :)

@trentm trentm mentioned this issue Apr 29, 2024
Closed
@kirrg001
Copy link
Contributor

kirrg001 commented May 6, 2024

@david-luna That would be nice. If you need any help, let me know.

@david-luna david-luna self-assigned this May 6, 2024
@david-luna david-luna mentioned this issue May 6, 2024
Merged
@kirrg001
Copy link
Contributor

@david-luna Could you please let me know if you want to add the support for v18 after the merge? Otherwise I will do it.

trentm added a commit that referenced this issue May 22, 2024
@david-luna @kirrg001 @trentm
feat(instr-tedious): add support for v16 and v17 (#2178)
8c578cd 
Closes: #1656
Co-authored-by: gurke <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
@dyladan dyladan mentioned this issue May 22, 2024
Merged
@kirrg001
Copy link
Contributor

kirrg001 commented Jun 3, 2024

@david-luna

@david-luna Could you please let me know if you want to add the support for v18 after the #2178? Otherwise I will do it.

@kirrg001 kirrg001 mentioned this issue Jun 7, 2024
Closed
@kirrg001
Copy link
Contributor

kirrg001 commented Jun 7, 2024

#2266
I will try to add support for v18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-luna david-luna

Labels
never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
4 participants
@david-luna @kirrg001 @mderriey @blumamir