-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove support for node 8-12, add 18 #1065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 96.07% 92.35% -3.73%
==========================================
Files 14 128 +114
Lines 892 6198 +5306
Branches 191 1213 +1022
==========================================
+ Hits 857 5724 +4867
- Misses 35 474 +439
|
github-actions
bot
assigned blumamir, legendecas, naseemkullah, NathanielRN, obecny, rauno56 and willarmiros
Jun 22, 2022
rauno56
force-pushed
the
chore/drop-eol-node
branch
from
June 27, 2022 16:09
0289f96
to
ef29bcf
Compare
rauno56
changed the title
chore: remove node 8 and 10 support add 18
chore: remove support for node 8-12, add 18
Jun 27, 2022
1 task
blumamir
approved these changes
Jun 27, 2022
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
1 task
…, not reference equality In the CI there will be 3 instances of the API installed(relative to the repo root): - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`, - `./node_modules/@opentelemetry/api`, - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`.
rauno56
force-pushed
the
chore/drop-eol-node
branch
from
September 9, 2022 14:47
29699ec
to
a29dcd3
Compare
1 task
dyladan
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
It's a complimentary PR for open-telemetry/opentelemetry-js#3048
Short description of the changes
Required changes for node@18:
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.