feat(instrumentation-aws-lambda): use require-in-the-middle directly
#1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 96.08% 95.53% -0.55%
==========================================
Files 14 16 +2
Lines 893 1097 +204
Branches 191 228 +37
==========================================
+ Hits 858 1048 +190
- Misses 35 49 +14
|
mhassan1
commented
Nov 29, 2022
| ] | ||
| ), | ||
| ]; | ||
| // Use RITM directly because `@opentelemetry/instrumentation` does not support absolute paths. |
There was a problem hiding this comment.
I think it might make more sense for this to happen inside an enable override, rather than in init.
2 tasks
|
Superseded by open-telemetry/opentelemetry-js#3457. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/instrumentation-aws-lambdais incompatible with@opentelemetry/instrumentation@^0.34.0and higher, since it no longer supports instrumentation of absolute paths. This PR switches to usingrequire-in-the-middledirectly.Fixes #1285
Short description of the changes
This PR replaces usage of
InstrumentationNodeModuleDefinitionandInstrumentationNodeModuleFilewith direct invocation ofrequire-in-the-middle. Any instrumentation plugins that instrument absolute paths will need to use this strategy; currently, this is the only one.One downside of this approach is that it does not use the normal instrumentation patching infrastructure, so some features (e.g.
instrumentation.disable) may not work.In #1285, we discussed a few options for resolving the need to instrument absolute paths. This PR represents option 3: